From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: drm: meson: Fix DMA max segment size for DMABUF imports Date: Thu, 04 Jun 2026 15:48:47 +1000 Message-ID: In-Reply-To: <20260530094326.11892-9-linux.amoon@gmail.com> References: <20260530094326.11892-1-linux.amoon@gmail.com> <20260530094326.11892-9-linux.amoon@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Fine as-is:** `dma_set_max_seg_size(dev, UINT_MAX)` is standard practice for DRM drivers that import DMABUFs. This suppresses legitimate DMA-API warnings when importing large contiguous buffers from the vdec driver. **Minor:** The commit message is well-written and explains the symptom (DMA-API warnings during v4l2m2m-copy playback). This is a straightforward and correct fix. --- **Summary:** The series addresses real problems but patches 3 (double-free), 5 (double-drain), and 7 (insufficient synchronization) need rework. Patch 2's approach of setting STATUS_INIT before hardware init creates a new race window. Patch 6's 64-bit DMA mask seems wrong for these SoCs. Patches 1, 4, and 8 are mostly correct but patch 1 has a minor error-path issue. --- Generated by Claude Code Patch Reviewer