From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: use drm backlight
Date: Thu, 04 Jun 2026 14:54:32 +1000
Message-ID: <review-patch8-20260531114908.1693426-9-superm1@kernel.org>
In-Reply-To: <20260531114908.1693426-9-superm1@kernel.org>
References: <20260531114908.1693426-1-superm1@kernel.org> <20260531114908.1693426-9-superm1@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status: Mostly good**

Links the backlight device to the DRM connector. The alloc happens in `init_helper` and the link in `register_backlight_device`, which is the right ordering.

**Minor nit**: Missing blank line before the `if (connector_type == DRM_MODE_CONNECTOR_HDMIA)`:
```c
+		if (r)
+			drm_err(dm->ddev, "Failed to allocate backlight: %d\n", r);
+	}
 	if (connector_type == DRM_MODE_CONNECTOR_HDMIA) {
```

Should have a blank line between the closing brace and the next if statement.

---
Generated by Claude Code Patch Reviewer