From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: rockchip: Add eDP node for RK3576 Date: Thu, 04 Jun 2026 14:37:03 +1000 Message-ID: In-Reply-To: <20260601065100.1103873-9-damon.ding@rock-chips.com> References: <20260601065100.1103873-1-damon.ding@rock-chips.com> <20260601065100.1103873-9-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Complete DTS node for RK3576 eDP controller: ```dts + edp: edp@27dc0000 { + compatible = "rockchip,rk3576-edp"; + reg = <0x0 0x27dc0000 0x0 0x1000>; + clocks = <&cru CLK_EDP0_24M>, <&cru PCLK_EDP0>, <&cru HCLK_VO0_ROOT>; + clock-names = "dp", "pclk", "hclk"; ``` Note the hclk here is `HCLK_VO0_ROOT` (not `HCLK_VO1` as in RK3588) since RK3576's eDP is on VO0, not VO1. The node structure follows the same pattern as RK3588. Has two resets (`dp` and `apb`), the phy, power domain, and grf reference. Has Reviewed-by from Nicolas Frattaroli. No issues. --- Generated by Claude Code Patch Reviewer