From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: break up dp_display_enable into two parts Date: Thu, 04 Jun 2026 13:01:24 +1000 Message-ID: In-Reply-To: <20260602-dp_mstclean-v6-8-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> <20260602-dp_mstclean-v6-8-2c17ff40a9b2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Splits enable into `msm_dp_display_prepare_link()` (link training, phy init) and `msm_dp_display_enable()` (stream on). Also renames variables from `dp`/`msm_dp_display` to avoid confusion. Minor: `msm_dp_display_prepare_link()` returns `rc` from `pm_runtime_resume_and_get()` when `sink_count == 0`, but `rc` at that point is 0 (the pm_runtime call succeeded). This means a zero sink_count returns success, which is the intended behavior since the caller checks `sink_count` separately. Fine. **No issues.** --- Generated by Claude Code Patch Reviewer