From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: video: cirrusfb: Make use of struct zorro_device_id::driver_data_ptr Date: Wed, 27 May 2026 14:47:33 +1000 Message-ID: In-Reply-To: <72b515651ab8df2f464deb620fd7b24370d6fb1a.1779803053.git.u.kleine-koenig@baylibre.com> References: <72b515651ab8df2f464deb620fd7b24370d6fb1a.1779803053.git.u.kleine-koenig@baylibre.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** This patch converts cirrusfb to use the new `driver_data_ptr` field. The ta= ble initialization changes from: ```c - .driver_data =3D (unsigned long)&zcl_sd64, + .driver_data_ptr =3D &zcl_sd64, ``` And the consumption site changes from: ```c - zcl =3D (const struct zorrocl *)ent->driver_data; + zcl =3D ent->driver_data_ptr; ``` Both directions of the conversion are correct: 1. **Initialization side:** Drops the `(unsigned long)` cast. The `const st= ruct zorrocl *` is implicitly converted to `const void *` =E2=80=94 this is= safe and preserves const. 2. **Usage side:** `ent->driver_data_ptr` is `const void *`, which is impli= citly converted to `const struct zorrocl *` in the assignment to `zcl`. Thi= s is valid C and preserves the const qualifier that was previously being ex= plicitly cast (actually correctly in the old code, but the cast was fragile= =E2=80=94 e.g., if someone changed the type of `zcl`, the old `(const stru= ct zorrocl *)` cast would silently hide any mismatch). 3. **Terminator cleanup:** `{ 0 }` =E2=86=92 `{ }` is consistent with patch= 5. 4. **Alignment reformatting:** The patch also drops the column-aligned `=3D= ` signs (e.g., `.id\t\t=3D` =E2=86=92 `.id =3D`). This is a minor style pre= ference; the kernel doesn't mandate column alignment in struct initializers= , so this is fine as a drive-by cleanup. No concerns. --- Generated by Claude Code Patch Reviewer