From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Apply drm_bridge_connector helper Date: Wed, 11 Feb 2026 16:37:17 +1000 Message-ID: In-Reply-To: <20260210071225.2566099-10-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-10-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Major refactoring to use drm_bridge_connector infrastructure instead of custom connector implementation. **Key changes:** - Removes custom `analogix_dp_connector_funcs` and `analogix_dp_connector_helper_funcs` - Converts connector operations to bridge operations - Changes attach behavior to require DRM_BRIDGE_ATTACH_NO_CONNECTOR ```c - if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { - DRM_ERROR("Fix bridge driver to make connector optional!"); + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { + DRM_ERROR("Unsupported connector creation\n"); ``` **Review:** - This is a significant API contract change - Good: Modernizes to current DRM bridge best practices - Good: Removes ~100 lines of boilerplate - The bridge_connector init code is added to platform drivers (exynos/rockchip) **CRC functions update:** ```c int analogix_dp_start_crc(struct drm_connector *connector) { - struct analogix_dp_device *dp = to_dp(connector); + struct analogix_dp_device *dp; + struct drm_bridge *bridge; + + bridge = drm_bridge_chain_get_first_bridge(connector->encoder); + if (bridge->type != DRM_MODE_CONNECTOR_eDP) + return -EINVAL; + + dp = to_dp(bridge); ``` **Issue:** `to_dp()` macro now takes a bridge instead of connector - verify all call sites are updated. **Verdict:** Well-executed modernization, verify no external API break age. --- --- Generated by Claude Code Patch Reviewer