public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: ARM: dts: imx6ul-var-som: add proper Wifi and Bluetooth support
Date: Tue, 03 Mar 2026 12:58:07 +1000	[thread overview]
Message-ID: <review-patch9-20260302190953.669325-10-hugo@hugovil.com> (raw)
In-Reply-To: <20260302190953.669325-10-hugo@hugovil.com>

Patch Review

**Issue 1 (Critical)**: In `imx6ull-var-som.dtsi`, the `MX6ULL_PAD_SNVS_TAMPER*` pads are placed under `&iomuxc`:

```c
&iomuxc {
    pinctrl_brcm_bt: brcm-bt-grp {
        fsl,pins = <
            MX6ULL_PAD_SNVS_TAMPER4__GPIO5_IO04  0x1b0b0
        >;
    };
    pinctrl_brcm_wifi: brcm-wifi-grp {
        fsl,pins = <
            MX6ULL_PAD_SNVS_TAMPER2__GPIO5_IO02  0x1b0b0
            MX6ULL_PAD_SNVS_TAMPER6__GPIO5_IO06  0x1b0b0
        >;
    };
};
```

On the imx6ull, the SNVS tamper pads belong to the separate `iomuxc_snvs` controller (defined in `imx6ull.dtsi` at `pinctrl@2290000`). All other imx6ull device trees in the kernel tree correctly use `&iomuxc_snvs` for these pads. This should be:

```c
&iomuxc_snvs {
    pinctrl_brcm_bt: ...
    pinctrl_brcm_wifi: ...
};
```

**Issue 2**: The `reg_sd1_vmmc` node name uses underscores:
```
reg_sd1_vmmc: regulator_sd1_vmmc {
```
DT naming convention prefers hyphens: `regulator-sd1-vmmc`.

**Issue 3**: The `imx6ul-var-som-wifi.dtsi` uses `GPIO_ACTIVE_HIGH` and `GPIO_ACTIVE_LOW` macros but doesn't include `<dt-bindings/gpio/gpio.h>`. It works because it's always included after files that already include it, but it's fragile. Consider adding the include.

**Issue 4**: The "full" naming convention (e.g., `imx6ul-var-som-concerto-full.dts`) is unconventional for upstream kernel DTS files. Typically DT variants are named for the specific option they enable. Something like `imx6ul-var-som-concerto-wifi.dts` might be more descriptive, or the approach used by other boards with board-level overlays.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03  2:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 19:03 [PATCH 00/14] var-som-6ul: improve support for variants Hugo Villeneuve
2026-03-02 19:03 ` [PATCH 01/14] ARM: dts: imx6ul-var-som: fix warning for non-existent dc-supply property Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 02/14] ARM: dts: imx6ul-var-som: fix warning for boolean property with a value Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 03/14] ARM: dts: imx6ul-var-som: change incorrect VAR-SOM-6UL model name Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 04/14] dt-bindings: arm: fsl: " Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 05/14] dt-bindings: arm: fsl: add variscite,var-som-imx6ull Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 06/14] ARM: dts: imx6ul-var-som: Factor out common parts for all CPU variants Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 07/14] ARM: dts: imx6ul-var-som-concerto: " Hugo Villeneuve
2026-03-02 20:50   ` Frank Li
2026-03-02 21:07     ` Hugo Villeneuve
2026-03-02 21:28       ` Frank Li
2026-03-02 21:36         ` Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 08/14] ARM: dts: imx6ul-var-som: factor out SD card support Hugo Villeneuve
2026-03-02 20:54   ` Frank Li
2026-03-02 21:15     ` Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 09/14] ARM: dts: imx6ul-var-som: add proper Wifi and Bluetooth support Hugo Villeneuve
2026-03-02 20:59   ` Frank Li
2026-03-02 21:42     ` Hugo Villeneuve
2026-03-03  2:58   ` Claude Code Review Bot [this message]
2026-03-02 19:03 ` [PATCH 10/14] ARM: dts: imx6ul-var-som: factor out ENET2 ethernet support Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 11/14] ARM: dts: imx6ul-var-som: add support for EC configuration option (ENET1) Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 12/14] ARM: dts: imx6ul-var-som: factor out audio support Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 13/14] dt-bindings: display/lvds-codec: add ti,sn65lvds93 Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 14/14] ARM: dts: imx6ul-var-som: add support for LVDS display panel Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-03  2:58 ` Claude review: var-som-6ul: improve support for variants Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch9-20260302190953.669325-10-hugo@hugovil.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox