From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add tests for continuation records Date: Thu, 05 Mar 2026 13:55:45 +1000 Message-ID: In-Reply-To: <20260304-cmdq-continuation-v5-9-3f19d759ed93@nvidia.com> References: <20260304-cmdq-continuation-v5-0-3f19d759ed93@nvidia.com> <20260304-cmdq-continuation-v5-9-3f19d759ed93@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good test coverage with boundary conditions: - 0 bytes payload (no split) - Exactly `MAX_FIRST_PAYLOAD` (no split, boundary) - `MAX_FIRST_PAYLOAD + 1` (first split) - `MAX_FIRST_PAYLOAD + MAX_CMD_SIZE` (single continuation, boundary) - `MAX_FIRST_PAYLOAD + MAX_CMD_SIZE + 1` (two continuations) - `MAX_FIRST_PAYLOAD + 3.5 * MAX_CMD_SIZE` (multiple continuations) The test pattern generation with `(i ^ (i >> 8)) as u8` ensures non-repeating patterns across 256-byte boundaries, which is a good approach for catching off-by-one copy errors. The `read_payload` helper correctly verifies payload content by reading back through the `CommandToGsp` interface. One minor style note: the `// SAFETY` comments on `TestHeader`'s `FromBytes`/`AsBytes` impls are straightforward since it's `[u8; 64]`. No issues. Overall this is a well-crafted series ready for merging, with the only substantive note being the zero poll interval choice in patch 2 which may deserve a comment or small delay. --- Generated by Claude Code Patch Reviewer