From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: MAINTAINERS: Add entry for i.MX94 DCIF driver Date: Thu, 05 Mar 2026 13:34:50 +1000 Message-ID: In-Reply-To: <20260304-dcif-upstreaming-v8-9-bec5c047edd4@oss.nxp.com> References: <20260304-dcif-upstreaming-v8-0-bec5c047edd4@oss.nxp.com> <20260304-dcif-upstreaming-v8-9-bec5c047edd4@oss.nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Standard MAINTAINERS entry. Covers both the binding doc and the driver dire= ctory. No issues. --- **Summary of issues found:** 1. **Bug**: `DCIF_MAX_PIXEL_CLOCK` is 148500000 (Hz) but compared against `= mode->crtc_clock` which is in kHz =E2=80=94 the mode_valid check is effecti= vely a no-op (dcif-crtc.c). 2. **Potential issue**: `__free(drm_bridge_put)` used on a bridge pointer t= hat may not have been refcount-incremented (dcif-crtc.c). 3. **Minor**: Dead code in CRC ROI parsing =E2=80=94 `params[i] < 0` check = after `kstrtouint` (dcif-crc.c). 4. **Minor**: YUV format rejection should be in `atomic_check` not `atomic_= update` (dcif-plane.c). 5. **Minor**: `dcif_driver` should be `const` (dcif-drv.c). 6. **Style**: Duplicate format-to-register mapping between CRTC and plane c= ode. --- Generated by Claude Code Patch Reviewer