From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort Date: Thu, 05 Mar 2026 13:38:01 +1000 Message-ID: In-Reply-To: <20260304094152.92-10-kernel@airkyi.com> References: <20260304094152.92-1-kernel@airkyi.com> <20260304094152.92-10-kernel@airkyi.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Board-level DTS additions for the EVB IND board. Adds fusb302 Type-C controller, connector description, DP PHY linkage. **Issue (minor): `sound` node uses `rockchip,rk3399-gru-sound` compatible.** The RK3399 EVB IND is not a Gru-based Chromebook. Using the Gru sound compatible may not be appropriate for this board unless the audio setup is identical. This should be verified against the actual hardware. **Observation:** The `vdo = <0x00001c46>` value in the DP altmode node -- the changelog mentions "Fix wrong vdo value" from v3. The value encodes DP capabilities; it should be reviewed by someone with access to the hardware spec. --- ## Summary of Issues Requiring Action 1. **Bug (must fix):** Patch 7 - `prev_port` uninitialized in `cdn_dp_bridge_edid_read()`. Initialize to `NULL`. 2. **Bug (must fix):** Patch 6 - `PTR_ERR(extcon) != -ENODEV` check fires on valid extcon pointers, breaking existing boards. Needs `IS_ERR(extcon) &&` guard. 3. **Bug (should fix):** Patch 7 - `cdn_dp_connected_port()` lost the `lanes` check for the extcon path, returning first port even with 0 lanes. 4. **Should fix:** Patch 1 - `to_typec_altmode()` cast before type check; ignored error return; missing `__exit`. 5. **Should fix:** Patch 4 - fwnode handle leaks in `tcphy_setup_orien_switch()` and `tcphy_setup_typec_mux()`. 6. **Minor:** Various naming inconsistencies and style nits. --- Generated by Claude Code Patch Reviewer