From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add tests for continuation records Date: Mon, 09 Mar 2026 09:11:27 +1000 Message-ID: In-Reply-To: <20260306-cmdq-continuation-v6-9-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> <20260306-cmdq-continuation-v6-9-cc7b629200ee@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Comprehensive kunit tests covering: - Zero payload (no split) - Payload exactly at `MAX_FIRST_PAYLOAD` (fits in one command) - Payload at `MAX_FIRST_PAYLOAD + 1` (triggers 1 continuation) - Payload at `MAX_FIRST_PAYLOAD + MAX_CMD_SIZE` (fills exactly 1 continuati= on) - Payload at `MAX_FIRST_PAYLOAD + MAX_CMD_SIZE + 1` (triggers 2 continuatio= ns) - Larger payload with fractional continuation fill The test verifies both the number of continuation records and that the conc= atenated data matches the original pattern. The `TestHeader` uses a 64-byte= struct to exercise the non-trivial case where the first command has less p= ayload space due to the header. The `TestPayload::generate_pattern` uses `(i ^ (i >> 8)) as u8` to avoid a = repeating 256-byte pattern, which is a nice touch for catching off-by-one e= rrors in splitting. One very minor nit: `read_payload` creates an `SBufferIter` with `[buf.as_m= ut_slice(), &mut []]` =E2=80=94 the empty second slice is fine but could ha= ve a brief comment. Not a blocking issue. No issues. Good test coverage. --- Generated by Claude Code Patch Reviewer