From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: remoteproc: qcom: Select QCOM_PAS_TEE service backend Date: Mon, 09 Mar 2026 08:59:09 +1000 Message-ID: In-Reply-To: <20260306105027.290375-10-sumit.garg@kernel.org> References: <20260306105027.290375-1-sumit.garg@kernel.org> <20260306105027.290375-10-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Kconfig anti-pattern: `select` with unmet dependencies.** This patch adds: ``` select QCOM_PAS_TEE ``` to `QCOM_Q6V5_PAS`, but `QCOM_PAS_TEE` has: ``` depends on TEE depends on !CPU_BIG_ENDIAN ``` Using `select` on a symbol that has `depends on` is a well-known Kconfig problem. If `TEE` is not enabled or `CPU_BIG_ENDIAN` is set, `QCOM_PAS_TEE` will be force-selected with unmet dependencies, leading to build errors. The fix is either: - Change `select` to `depends on` or `imply`, or - Remove the `depends on` from `QCOM_PAS_TEE` and add the dependencies to the selecting symbol, or - Use `imply QCOM_PAS_TEE` instead of `select`. --- Generated by Claude Code Patch Reviewer