From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/color: Program Plane Post CSC registers for SDR planes Date: Mon, 09 Mar 2026 08:26:54 +1000 Message-ID: In-Reply-To: <20260306165307.3233194-10-chaitanya.kumar.borah@intel.com> References: <20260306165307.3233194-1-chaitanya.kumar.borah@intel.com> <20260306165307.3233194-10-chaitanya.kumar.borah@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Same bugs as patch 7:** 1. **Wrong extract function**: Uses `drm_color_lut32_extract(post_csc_lut[i= ].green, 16)` =E2=80=94 wait, this one actually uses `drm_color_lut32_extra= ct`, which is correct. But wait, let me re-check: ```c lut_val =3D drm_color_lut32_extract(post_csc_lut[i].green, 16); ``` Actually, looking again at the diff: patch 9 uses `drm_color_lut32_extract`= =E2=80=94 this is **correct** for the post-CSC SDR function. But patch 7 (= pre-CSC SDR) uses `drm_color_lut_extract` =E2=80=94 that's the inconsistenc= y and bug. 2. **Same hardcoded `plane =3D plane - 3`** concern as patch 7. --- Generated by Claude Code Patch Reviewer