From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Documentation: ABI: Add sysfs ABI documentation for DDR training data
Date: Mon, 09 Mar 2026 08:09:02 +1000 [thread overview]
Message-ID: <review-patch9-20260307-sahara_protocol_new_v2-v2-9-29dc748b5e9c@oss.qualcomm.com> (raw)
In-Reply-To: <20260307-sahara_protocol_new_v2-v2-9-29dc748b5e9c@oss.qualcomm.com>
Patch Review
- **ABI doc file naming** -- typically sysfs ABI docs are named `sysfs-bus-mhi` (for the bus) not `sysfs-bus-mhi-ddr_training_data`. Check existing convention -- if there's already a `sysfs-bus-mhi` file, this should be appended to it.
- **Path in the ABI doc:**
```
What: /sys/bus/mhi/devices/<mhi-cntrl>/ddr_training_data
```
The attribute is created on `mhi_dev->mhi_cntrl->mhi_dev->dev`, which is the MHI controller's mhi_dev. Verify that the documented path matches the actual sysfs location.
- **Missing `Users:` field** -- ABI documentation typically includes a `Users:` field.
- **`Usage:` and `Permissions:` are non-standard fields** for ABI documentation. The standard fields are `What`, `Date`, `KernelVersion`, `Contact`, `Description`. The permission info should go in `Description`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 22:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 11:41 [PATCH v2 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-07 11:41 ` [PATCH v2 1/9] Add documentation for Sahara protocol Kishore Batta
2026-03-07 19:50 ` kernel test robot
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 3/9] bus: mhi: Match devices exposing the protocol on the SAHARA channel Kishore Batta
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 4/9] bus: mhi: Centralize firmware image table selection at probe time Kishore Batta
2026-03-08 8:56 ` kernel test robot
2026-03-08 9:27 ` kernel test robot
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 5/9] bus: mhi: Add QDU100 firmware image table Kishore Batta
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 6/9] bus: mhi: Load DDR training data using per-device serial number Kishore Batta
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 7/9] bus: mhi: Capture DDR training data using command mode Kishore Batta
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 8/9] bus: mhi: Expose DDR training data via controller sysfs Kishore Batta
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 9/9] Documentation: ABI: Add sysfs ABI documentation for DDR training data Kishore Batta
2026-03-08 22:09 ` Claude Code Review Bot [this message]
2026-03-08 22:08 ` Claude review: Qualcomm Sahara protocol enhancements Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 7:21 [PATCH v3 0/9] " Kishore Batta
2026-03-10 7:22 ` [PATCH v3 9/9] Documentation: ABI: Add sysfs ABI documentation for DDR training data Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-19 6:31 [PATCH v4 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-19 6:31 ` [PATCH v4 9/9] Documentation: ABI: Add sysfs ABI documentation for DDR training data Kishore Batta
2026-03-21 18:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch9-20260307-sahara_protocol_new_v2-v2-9-29dc748b5e9c@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox