From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Documentation: ABI: Add sysfs ABI documentation for DDR training data
Date: Mon, 09 Mar 2026 08:09:02 +1000
Message-ID: <review-patch9-20260307-sahara_protocol_new_v2-v2-9-29dc748b5e9c@oss.qualcomm.com>
In-Reply-To: <20260307-sahara_protocol_new_v2-v2-9-29dc748b5e9c@oss.qualcomm.com>
References: <20260307-sahara_protocol_new_v2-v2-0-29dc748b5e9c@oss.qualcomm.com> <20260307-sahara_protocol_new_v2-v2-9-29dc748b5e9c@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

- **ABI doc file naming** -- typically sysfs ABI docs are named `sysfs-bus-mhi` (for the bus) not `sysfs-bus-mhi-ddr_training_data`. Check existing convention -- if there's already a `sysfs-bus-mhi` file, this should be appended to it.

- **Path in the ABI doc:**
  ```
  What:     /sys/bus/mhi/devices/<mhi-cntrl>/ddr_training_data
  ```
  The attribute is created on `mhi_dev->mhi_cntrl->mhi_dev->dev`, which is the MHI controller's mhi_dev. Verify that the documented path matches the actual sysfs location.

- **Missing `Users:` field** -- ABI documentation typically includes a `Users:` field.

- **`Usage:` and `Permissions:` are non-standard fields** for ABI documentation. The standard fields are `What`, `Date`, `KernelVersion`, `Contact`, `Description`. The permission info should go in `Description`.

---
Generated by Claude Code Patch Reviewer