From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/drv: Call drm_mode_config_create_state() by default Date: Wed, 11 Mar 2026 13:09:08 +1000 Message-ID: In-Reply-To: <20260310-drm-mode-config-init-v1-9-de7397c8e1cf@kernel.org> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> <20260310-drm-mode-config-init-v1-9-de7397c8e1cf@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This hooks `drm_mode_config_create_state()` into `drm_dev_register()`. The placement after `drm_modeset_register_all()` makes sense. The `goto err_unload` on failure is correct. However, this means any driver that currently relies on `drm_mode_config_reset()` called before `drm_dev_register()` will now have states created twice - first by `reset()`, then skipped by `create_state()` due to the `if (plane->state) continue;` guards. This is fine and intentional for the transition period. --- Generated by Claude Code Patch Reviewer