From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Documentation: ABI: Add sysfs ABI documentation for DDR training data Date: Wed, 11 Mar 2026 13:35:24 +1000 Message-ID: In-Reply-To: <20260310-sahara_protocol_new_v2-v3-9-994ea4b0d5ad@oss.qualcomm.com> References: <20260310-sahara_protocol_new_v2-v3-0-994ea4b0d5ad@oss.qualcomm.com> <20260310-sahara_protocol_new_v2-v3-9-994ea4b0d5ad@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds ABI documentation for the sysfs attribute. **Issues:** - The `Usage` and `Permissions` fields are not standard ABI documentation f= ields. Standard fields are `What`, `Date`, `KernelVersion`, `Contact`, `Des= cription`. The extra fields will likely cause warnings from the ABI documen= tation checker. - Missing `KernelVersion:` field, which is expected. - The ABI file name `sysfs-bus-mhi-ddr_training_data` doesn't follow the ex= isting MHI ABI naming conventions =E2=80=94 it should probably just extend = the existing `sysfs-bus-mhi` file. --- Generated by Claude Code Patch Reviewer