From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: remoteproc: qcom: Select QCOM_PAS_TEE service backend Date: Fri, 13 Mar 2026 14:26:33 +1000 Message-ID: In-Reply-To: <20260312062756.694390-10-sumit.garg@kernel.org> References: <20260312062756.694390-1-sumit.garg@kernel.org> <20260312062756.694390-10-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `select QCOM_PAS_TEE` to `QCOM_Q6V5_PAS`. This means enabling `QCOM_Q6= V5_PAS` will pull in the TEE backend unconditionally (if `TEE` is available= and `!CPU_BIG_ENDIAN`). Since `QCOM_PAS_TEE` has `depends on TEE` and `dep= ends on !CPU_BIG_ENDIAN`, using `select` here can create Kconfig dependency= issues if TEE isn't enabled =E2=80=94 `select` ignores `depends on` of the= selected symbol. This could lead to build failures on big-endian configs o= r configs without TEE. Should this be `imply QCOM_PAS_TEE` instead? --- Generated by Claude Code Patch Reviewer