From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Documentation: ABI: Add sysfs ABI documentation for DDR training data Date: Sun, 22 Mar 2026 04:44:35 +1000 Message-ID: In-Reply-To: <20260319-sahara_protocol_new_v2-v4-9-47ad79308762@oss.qualcomm.com> References: <20260319-sahara_protocol_new_v2-v4-0-47ad79308762@oss.qualcomm.com> <20260319-sahara_protocol_new_v2-v4-9-47ad79308762@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds ABI documentation for the `ddr_training_data` sysfs node. **Issues:** - **Missing `KernelVersion:` field** =E2=80=94 standard ABI documentation i= ncludes this. - **Non-standard fields**: `Usage:` and `Permissions:` are not standard ABI= documentation fields and may cause warnings with ABI documentation tooling. - **`cat` recommended for binary data**: The example uses `cat` which is in= appropriate for binary content. Use `cp` or `dd` instead. - **Excessive blank lines** between ABI documentation fields =E2=80=94 not = consistent with standard kernel ABI format. --- Generated by Claude Code Patch Reviewer