public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: analogix_dp: Add support for RK3576
Date: Sun, 22 Mar 2026 04:26:16 +1000	[thread overview]
Message-ID: <review-patch9-20260320004554.2006299-1-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260320004554.2006299-1-damon.ding@rock-chips.com>

Patch Review

```c
+static const struct rockchip_dp_chip_data rk3576_edp[] = {
+	{
+		.chip_type = RK3576_EDP,
+		.reg = 0x27dc0000,
+	},
+	{ /* sentinel */ }
+};
```

**Notable difference from RK3588**: The RK3576 chip_data does not set `.edp_mode`, unlike RK3588 which has:
```c
.edp_mode = GRF_REG_FIELD(0x0000, 0, 0),
```

This means `rockchip_dp_poweron()` will call `rockchip_grf_field_write(dp->grf, &dp->data->edp_mode, 1)` which checks `field->valid` (which will be `false` since `.edp_mode` is zero-initialized) and returns 0 — so it's a no-op. This is correct behavior if RK3576 doesn't need the edp_mode GRF write, but it would be worth a brief comment or commit message note explaining why this isn't needed for RK3576.

Similarly, `.lcdc_sel` is not set, so the GRF write in `rockchip_dp_drm_encoder_enable()` will also be a no-op. This seems intentional but should be confirmed — does RK3576 not need VOP output routing via GRF?

The Reviewed-by tag from Nicolas Frattaroli is present. The change is otherwise straightforward and follows existing patterns.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-21 18:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 10:40 [PATCH v2 0/9] Add eDP support for RK3576 Damon Ding
2026-03-19 10:40 ` [PATCH v2 1/9] dt-bindings: display: rockchip: analogix-dp: Expand clock-names "hclk" for the third clock Damon Ding
2026-03-20  9:19   ` Krzysztof Kozlowski
2026-03-20  9:41     ` Krzysztof Kozlowski
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 2/9] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP0 nodes Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 3/9] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP1 nodes Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 4/9] drm/rockchip: analogix_dp: Enable clock "hclk" for RK3588 Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 5/9] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 6/9] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 7/9] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 8/9] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-20  0:45 ` [PATCH v2 9/9] drm/rockchip: " Damon Ding
2026-03-21 18:26   ` Claude Code Review Bot [this message]
2026-03-21 18:26 ` Claude review: Add eDP " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10 10:53 [PATCH v1 0/4] " Damon Ding
2026-03-10 10:53 ` [PATCH v1 4/4] drm/rockchip: analogix_dp: Add " Damon Ding
2026-03-11  3:27   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch9-20260320004554.2006299-1-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox