From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: analogix_dp: Add support for RK3576 Date: Sun, 22 Mar 2026 04:26:16 +1000 Message-ID: In-Reply-To: <20260320004554.2006299-1-damon.ding@rock-chips.com> References: <20260319104031.1986946-1-damon.ding@rock-chips.com> <20260320004554.2006299-1-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review ```c +static const struct rockchip_dp_chip_data rk3576_edp[] =3D { + { + .chip_type =3D RK3576_EDP, + .reg =3D 0x27dc0000, + }, + { /* sentinel */ } +}; ``` **Notable difference from RK3588**: The RK3576 chip_data does not set `.edp= _mode`, unlike RK3588 which has: ```c .edp_mode =3D GRF_REG_FIELD(0x0000, 0, 0), ``` This means `rockchip_dp_poweron()` will call `rockchip_grf_field_write(dp->= grf, &dp->data->edp_mode, 1)` which checks `field->valid` (which will be `f= alse` since `.edp_mode` is zero-initialized) and returns 0 =E2=80=94 so it'= s a no-op. This is correct behavior if RK3576 doesn't need the edp_mode GRF= write, but it would be worth a brief comment or commit message note explai= ning why this isn't needed for RK3576. Similarly, `.lcdc_sel` is not set, so the GRF write in `rockchip_dp_drm_enc= oder_enable()` will also be a no-op. This seems intentional but should be c= onfirmed =E2=80=94 does RK3576 not need VOP output routing via GRF? The Reviewed-by tag from Nicolas Frattaroli is present. The change is other= wise straightforward and follows existing patterns. --- Generated by Claude Code Patch Reviewer