From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: Implement gx_is_on() for A8x Date: Wed, 25 Mar 2026 07:32:10 +1000 Message-ID: In-Reply-To: <20260324-a8xx-gpu-batch2-v1-9-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-9-fc95b8d9c017@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good refactoring =E2=80=94 moves `gx_is_on()` to the adreno_gpu_funcs vtabl= e so A8xx can provide its own implementation using `REG_A8XX_GMU_PWR_CLK_ST= ATUS`. The function signature change from `struct a6xx_gmu *` to `struct adreno_gp= u *` is clean and all callers are updated. --- Generated by Claude Code Patch Reviewer