From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbcon: Fill cursor mask in helper function Date: Sun, 12 Apr 2026 13:55:03 +1000 Message-ID: In-Reply-To: <20260407092555.58816-10-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> <20260407092555.58816-10-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Correct consolidation, minor style nit.** Consolidates four copies of cursor mask creation into `fbcon_fill_cursor_mask()`. The function creates a standard (non-rotated) mask, and the rotation-specific cursor functions then rotate it. This is a clean decomposition. Verified that the behavioral change in `ud_cursor` (previously built the mask in reversed order, now builds normal + rotates 180) produces the same visual result. For full-width masks (all bits set or clear per row), the horizontal flip in 180-degree rotation is a no-op, so only the vertical flip matters, which correctly inverts the row order. **Minor nit**: The `par` parameter to `fbcon_fill_cursor_mask()` is unused in the function body. The function only uses `vc` and `mask`. Consider removing the `par` parameter, or if it's intended for future use, document why it's there. The `static const unsigned int pattern = 0xffffffff` with casts to `unsigned char` is a bit roundabout. A simple `0xff` / `0x00` would be clearer, but this is harmless and was apparently chosen to fix a sparse warning. --- --- Generated by Claude Code Patch Reviewer