From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/hdmi: Add YCBCR444 handling for sink formats Date: Sun, 12 Apr 2026 11:01:42 +1000 Message-ID: In-Reply-To: <20260409-color-format-v12-9-ce84e1817a27@collabora.com> References: <20260409-color-format-v12-0-ce84e1817a27@collabora.com> <20260409-color-format-v12-9-ce84e1817a27@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds YCBCR444 cases to `intel_hdmi_sink_bpc_possible()` and `intel_hdmi_sink_format_valid()`: ```c case INTEL_OUTPUT_FORMAT_RGB: return MODE_OK; case INTEL_OUTPUT_FORMAT_YCBCR444: if (!(info->color_formats & BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444))) return MODE_BAD; return MODE_OK; ``` Note: the `case INTEL_OUTPUT_FORMAT_RGB: return MODE_OK;` followed immediately by `case INTEL_OUTPUT_FORMAT_YCBCR444:` means the RGB case no longer falls through to default. This is a **behavioral change** even for the non-color-format path -- previously RGB would have hit the `default: MISSING_CASE()` path. This appears intentional based on the existing code structure (RGB was presumably handled before the default), but verify that the baseline code before this patch already had a `case INTEL_OUTPUT_FORMAT_RGB` returning `MODE_OK` above the default. **Verdict**: Looks correct but double-check the pre-existing RGB case doesn't depend on fallthrough. --- --- Generated by Claude Code Patch Reviewer