From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi_qp: Register HPD IRQ after connector setup Date: Tue, 28 Apr 2026 15:25:21 +1000 Message-ID: In-Reply-To: <20260426-dw-hdmi-qp-scramb-v5-9-d778e70c317b@collabora.com> References: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> <20260426-dw-hdmi-qp-scramb-v5-9-d778e70c317b@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Moves `devm_request_threaded_irq()` to after `drm_bridge_connector_init()` = and `drm_connector_attach_encoder()`. This prevents HPD interrupts from fir= ing before the DRM connector is fully wired up. Also adds error handling for `drm_connector_attach_encoder()` which was pre= viously unchecked (the return value was just passed through as the function= 's return, but without an error message): ```c + ret =3D drm_connector_attach_encoder(connector, encoder); + if (ret) + return dev_err_probe(dev, ret, "Failed to attach connector\n"); ``` The IRQ is now the last thing registered, which means it will be the first = thing torn down by `devm` on unbind =E2=80=94 correct ordering. Has R-b from Heiko. **No issues.** --- --- Generated by Claude Code Patch Reviewer