From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: remoteproc: qcom: Select QCOM_PAS generic service Date: Tue, 28 Apr 2026 14:49:24 +1000 Message-ID: In-Reply-To: <20260427095603.1157963-10-sumit.garg@kernel.org> References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-10-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `select QCOM_PAS` to `QCOM_Q6V5_PAS` Kconfig. However, `QCOM_Q6V5_PAS` already does `select QCOM_SCM`, and in patch 3, `QCOM_SCM` does `select QCOM_PAS`. So this `select QCOM_PAS` is technically redundant. It's defensively correct though -- if in the future QCOM_SCM stopped selecting QCOM_PAS, this would still work. Acceptable. --- Generated by Claude Code Patch Reviewer