From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: synopsys: dw-dp: Add Runtime PM support Date: Tue, 05 May 2026 09:49:47 +1000 Message-ID: In-Reply-To: <20260501-synopsys-dw-dp-improvements-v2-9-d7e7f6bac77f@collabora.com> References: <20260501-synopsys-dw-dp-improvements-v2-0-d7e7f6bac77f@collabora.com> <20260501-synopsys-dw-dp-improvements-v2-9-d7e7f6bac77f@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `dw_dp_runtime_suspend`/`dw_dp_runtime_resume` exported functions and = sprinkles `ACQUIRE(pm_runtime_active_auto, pm)` / `pm_runtime_get_sync` / `= pm_runtime_put_autosuspend` at appropriate points. **Issue =E2=80=94 no error checking on `clk_prepare_enable` in resume:** ```c +int dw_dp_runtime_resume(struct dw_dp *dp) +{ + clk_prepare_enable(dp->apb_clk); + clk_prepare_enable(dp->aux_clk); + dw_dp_init_hw(dp); + return 0; +} ``` `clk_prepare_enable()` can fail but return values are ignored. The suspend = path also does unconditional `clk_disable_unprepare` without checking if th= ey were successfully enabled. **Issue =E2=80=94 `pm_runtime_get_sync` in `atomic_enable` without error ch= eck:** ```c + pm_runtime_get_sync(dp->dev); ``` `pm_runtime_get_sync()` can return errors, and if it does, the function con= tinues anyway. This should at minimum check the return value. The `ACQUIRE`= guard pattern used elsewhere is actually better because it's scoped, but `= atomic_enable` needs the device to stay active until `atomic_disable`, so t= he get/put pair is correct =E2=80=94 just needs error handling. --- Generated by Claude Code Patch Reviewer