From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: remoteproc: qcom: Select QCOM_PAS generic service Date: Tue, 05 May 2026 08:22:45 +1000 Message-ID: In-Reply-To: <20260504130603.1474043-10-sumit.garg@kernel.org> References: <20260504130603.1474043-1-sumit.garg@kernel.org> <20260504130603.1474043-10-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Kconfig changes to `select QCOM_PAS` for the remoteproc drivers. **Observation:** `QCOM_WCNSS_PIL` changes from `select QCOM_SCM` to `select QCOM_PAS`, while `QCOM_Q6V5_MSS` and `QCOM_Q6V5_PAS` *add* `select QCOM_PAS` while keeping `select QCOM_SCM`. This difference is intentional: wcnss no longer calls any SCM APIs directly after patch 8, while mss and pas still use SCM for non-PAS calls (e.g., `qcom_scm_mem_protect_video_var`). Good. No issues. --- --- Generated by Claude Code Patch Reviewer