From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi: Configure HDMI PHY in atomic_mode_set() Date: Sat, 16 May 2026 16:14:40 +1000 Message-ID: In-Reply-To: <20260510183114.1248840-10-jonas@kwiboo.se> References: <20260510183114.1248840-1-jonas@kwiboo.se> <20260510183114.1248840-10-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Clean** Replaces the legacy `mode_set()` encoder helper with `atomic_mode_set()`, which provides access to `crtc_state` and `conn_state`. This enables reading `conn_state->hdmi.tmds_char_rate` and `conn_state->hdmi.output_bpc` to configure the PHY. The `phy_configure()` call is guarded by `hdmi->phy && conn_state->hdmi.tmds_char_rate`, which is correct -- only SoCs with an external PHY and a valid TMDS rate will configure it. The `phy_validate()` in `atomic_check` mirrors the same guard. The `clk_set_rate()` call now uses `&crtc_state->adjusted_mode` instead of the `adj_mode` parameter, which is the same data accessed differently. The commit message correctly notes this has no functional impact until the dw-hdmi bridge is fully converted. No issues. --- --- Generated by Claude Code Patch Reviewer