From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: convert dcn42 GPIO translation to lookup tables Date: Sat, 16 May 2026 13:03:15 +1000 Message-ID: In-Reply-To: <20260512190019.228440-10-guilherme.bozi@usp.br> References: <20260512190019.228440-1-guilherme.bozi@usp.br> <20260512190019.228440-10-guilherme.bozi@usp.br> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good use of `GPIO_ENTRY()` (no mask check) for the HPD entries, since the original dcn42 code explicitly discarded the mask with `(void)mask`. The `gpio_offsets[]` contains only HPD entries, and `gpio_pins[]` contains only DDC entries -- no GENERIC, GSL, or SYNCA -- matching the original minimal implementation for this generation. No issues. --- **Summary**: Well-executed mechanical refactoring. The only actionable item is the minor alignment nit in patch 2/9 on the I2C_PAD DDC_CLOCK entry. The behavioral change around previously-silent-return offsets (PWRSEQ, PAD_STRENGTH, DEBUG) in dcn10 now hitting ASSERT_CRITICAL is arguably an improvement rather than a concern. --- Generated by Claude Code Patch Reviewer