From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/xe_ras: Control xe drm_ras registration with a flag Date: Sat, 16 May 2026 12:54:51 +1000 Message-ID: In-Reply-To: <20260512191610.1817578-10-raag.jadav@intel.com> References: <20260512191610.1817578-1-raag.jadav@intel.com> <20260512191610.1817578-10-raag.jadav@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Replaces the hard-coded `XE_PVC` platform check with a `has_drm_ras` device= info flag, and enables it for PVC and CRI (Crescent Island). **Issue: Malformed Reviewed-by tag.** ``` Reviewed-by: Raag Jadav ` =E2=80=94 = missing the closing `>` and has an extra `g`. This will fail `checkpatch.pl= ` and needs to be fixed. The approach of using a capability flag instead of a platform check is the = right pattern for xe driver. Clean implementation. --- ### Summary of actionable items: 1. **Patch 7**: Add NULL check for `info[error_id].name` in `query_correcta= ble_error_threshold` to avoid passing NULL to `nla_put_string()` =E2=80=94 = potential NULL pointer dereference / kernel oops. 2. **Patch 5/6**: Consider adding bounds validation in `xe_ras_get_threshol= d()` / `xe_ras_set_threshold()` for the `severity` and `component` paramete= rs before using them as array indices. 3. **Patch 8**: Fix "gove"/"gardware" typos in commit message; use `%pe` fo= rmat for errno printing. 4. **Patch 9**: Fix malformed `Reviewed-by` tag (`intel.comg` =E2=86=92 `in= tel.com>`). 5. **Patch 6**: Remove stray semicolon after `ras_status_to_errno()`. 6. **Patch 2**: Consider whether `admin-perm` is truly needed for a read-on= ly threshold query. --- Generated by Claude Code Patch Reviewer