From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vkms: Set DRM_VBLANK_FLAG_SIMULATED
Date: Sat, 16 May 2026 09:20:29 +1000
Message-ID: <review-patch9-20260515120916.333614-10-tzimmermann@suse.de>
In-Reply-To: <20260515120916.333614-10-tzimmermann@suse.de>
References: <20260515120916.333614-1-tzimmermann@suse.de> <20260515120916.333614-10-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Mechanical conversion:
```c
-	ret = drm_vblank_init(&vkms_device->drm,
-			      vkms_config_get_num_crtcs(config));
+	ret = drmm_vblank_init(&vkms_device->drm, vkms_config_get_num_crtcs(config),
+			       DRM_VBLANK_FLAG_SIMULATED);
```

Correct. VKMS is the virtual KMS driver, entirely software-based.

---

**Summary of items to address:**
1. **`BIT(1)` vs `BIT(0)`** (patch 2): Either use `BIT(0)` or explain the gap.
2. **Missing kernel-doc** for `drm_vblank_crtc.flags` (patch 1): Add a `/** @flags: ... */` comment.

---
Generated by Claude Code Patch Reviewer