From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/syncobj: fix resource leak in drm_syncobj_import_sync_file_fence
Date: Mon, 18 May 2026 16:53:32 +1000
Message-ID: <review-patch9-20260516-jorth-syncobj-v1-9-88ede9d98a81@gmail.com>
In-Reply-To: <20260516-jorth-syncobj-v1-9-88ede9d98a81@gmail.com>
References: <20260516-jorth-syncobj-v1-0-88ede9d98a81@gmail.com> <20260516-jorth-syncobj-v1-9-88ede9d98a81@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**This is a real bug fix.** In the current upstream code:

```c
if (!chain)
    return -ENOMEM;  /* leaks fence and syncobj refs */
```

At line 744-745 of the current tree, if `dma_fence_chain_alloc()` fails, the function returns immediately without calling `dma_fence_put(fence)` or `drm_syncobj_put(syncobj)`.

The fix is correct. However:
- This should be submitted as a **separate standalone patch** with a `Fixes:` tag, not bundled in a feature series. It's a legitimate bug in current mainline.
- The patch could use `Fixes: <commit-hash> ("drm/syncobj: add timeline point support")` or whichever commit introduced the `point` parameter.

---
Generated by Claude Code Patch Reviewer