From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: bridge_connector: Switch to .detect_ctx() connector helper Date: Mon, 25 May 2026 21:15:04 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-9-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> <20260520-dw-hdmi-qp-scramb-v6-9-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is an important structural change. The `.detect()` callback on `drm_co= nnector_funcs` is replaced with `.detect_ctx()` on `drm_connector_helper_fu= ncs`. **Key concern =E2=80=94 non-EDEADLOCK error handling**: When `drm_atomic_he= lper_connector_hdmi_hotplug_ctx()` returns a non-EDEADLOCK error, the code = falls through and still returns `status` (cast to int). Since connector_sta= tus enum values are non-negative (0=3Dunknown, 1=3Dconnected, 2=3Ddisconnec= ted), and errors are negative, the caller can distinguish them. But the *er= ror from the SCDC sync is silently ignored* =E2=80=94 the connector status = is reported normally even if the CRTC reset failed. This is probably intent= ional (you still want to report the connection, even if SCDC recovery faile= d), but worth noting. --- Generated by Claude Code Patch Reviewer