From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: sc8280xp-arcata: model the PMU of the on-board wcn6855 Date: Mon, 25 May 2026 21:20:10 +1000 Message-ID: In-Reply-To: <20260520-surface-sp9-5g-for-next-v1-9-9df52552bf87@gmail.com> References: <20260520-surface-sp9-5g-for-next-v1-0-9df52552bf87@gmail.com> <20260520-surface-sp9-5g-for-next-v1-9-9df52552bf87@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Issue: Deprecated BT supply name.** The WCN6855 PMU node itself is correc= t and matches the X13s exactly. The wifi supply rewiring and removal of `re= gulator-always-on` from `vreg_s11b`/`vreg_s12b` are correct. However, the **bluetooth node uses `vddrfa1p7-supply`** which is marked as = **deprecated** in the binding (`Documentation/devicetree/bindings/net/bluet= ooth/qcom,wcn6855-bt.yaml`). The binding requires `vddrfa1p8-supply`, and t= he X13s uses `vddrfa1p8-supply`: ```diff # Patch 09 (arcata) - uses deprecated name: + vddrfa1p7-supply =3D <&vreg_pmu_rfa_1p7>; # X13s reference - uses correct name: vddrfa1p8-supply =3D <&vreg_pmu_rfa_1p7>; ``` The commit message says "Use the fixed BT vddrfa1p7-supply supply name to a= lign with bindings" but this is the opposite of what the binding requires = =E2=80=94 `vddrfa1p7` is deprecated and `vddrfa1p8` is required. Notably, t= he **wifi node** in the same patch correctly uses `vddrfa1p8-supply`, makin= g this inconsistency more obvious: ``` + vddrfa1p8-supply =3D <&vreg_pmu_rfa_1p7>; /* wifi - correct */ ``` This should be changed to `vddrfa1p8-supply` to match the binding and the X= 13s. --- Generated by Claude Code Patch Reviewer