From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Add support for RK3576 Date: Mon, 25 May 2026 20:40:14 +1000 Message-ID: In-Reply-To: <20260521080835.1362416-10-damon.ding@rock-chips.com> References: <20260521080835.1362416-1-damon.ding@rock-chips.com> <20260521080835.1362416-10-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `RK3576_EDP` to the enum (in correct sorted position), updates `analogix_dp_is_rockchip()`, and falls through to RK3588_EDP in `analogix_dp_dt_parse_pdata()`: ```c + case RK3576_EDP: case RK3588_EDP: video_info->max_link_rate = 0x14; video_info->max_lane_count = 0x04; break; ``` The fallthrough is appropriate since RK3576 and RK3588 share the same max link rate (5.4 Gbps) and lane count (4). This is implicit fallthrough without a `fallthrough;` annotation, which works fine since there's no code between the two case labels (GCC/Clang don't warn on this pattern). No issues. --- Generated by Claude Code Patch Reviewer