From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi-state-helper: Try subsampling in mode_valid Date: Mon, 25 May 2026 18:48:55 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-9-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-9-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good bugfix with a Fixes tag. The logic correctly handles 420-only modes by checking `ycbcr_420_allowed` first, and 420-also modes by preferring YUV420 validation (which requires less bandwidth). One question about the 420-also path: it always validates using YUV420 for 420-also modes when `ycbcr_420_allowed` is set, even if the mode would work fine in RGB. This is fine for `mode_valid` (which only needs to confirm the mode *can* work), but worth confirming that using YUV420's halved clock for validation doesn't accidentally accept modes that can't actually work in the format the driver will ultimately choose. --- Generated by Claude Code Patch Reviewer