From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi-state-helper: Try subsampling in mode_valid Date: Mon, 25 May 2026 17:26:10 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-9-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> <20260523-color-format-v16-9-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good bugfix. Without this, 420-only modes (e.g., 4K@60Hz on HDMI 1.4 sinks)= would be rejected by `mode_valid` because it was computing the clock rate = assuming RGB. The fix correctly computes the clock using YCbCr420's halved = pixel clock for 420-capable modes. **Observation:** For `drm_mode_is_420_also()` modes, this always uses YCbCr= 420 for the clock calculation. This means `mode_valid` will accept such mod= es even if the actual selected color format (e.g., RGB) would exceed the cl= ock limit. That's acceptable because `mode_valid` is a fast filter =E2=80= =94 the detailed check happens in `atomic_check` =E2=80=94 but it is permis= sive. The Fixes: tag is appropriate. --- Generated by Claude Code Patch Reviewer