From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: vbios: keep PmuLookupTable local in setup_falcon_data Date: Tue, 26 May 2026 07:03:41 +1000 Message-ID: In-Reply-To: <20260525-fix-vbios-v5-9-e5e455251537@nvidia.com> References: <20260525-fix-vbios-v5-0-e5e455251537@nvidia.com> <20260525-fix-vbios-v5-9-e5e455251537@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good simplification. `pmu_lookup_table` was stored in `FwSecBiosBuilder` but only used within `setup_falcon_data`, so it can be a local variable. Also adds a `.get(offset..).ok_or(EINVAL)?` bounds check in the `else` branch that was missing before (the `first_fwsec` branch still uses direct indexing `&first_fwsec.base.data[offset..]` -- but that is on the first_fwsec which is passed by reference and the offset was already validated to be within the first fwsec in prior patches). No issues. --- Generated by Claude Code Patch Reviewer