From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Set DRM_VBLANK_FLAG_SIMULATED Date: Thu, 28 May 2026 12:19:16 +1000 Message-ID: In-Reply-To: <20260527133917.207150-10-tzimmermann@suse.de> References: <20260527133917.207150-1-tzimmermann@suse.de> <20260527133917.207150-10-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review ```c - ret =3D drm_vblank_init(&vkms_device->drm, - vkms_config_get_num_crtcs(config)); + ret =3D drmm_vblank_init(&vkms_device->drm, vkms_config_get_num_crtcs(con= fig), + DRM_VBLANK_FLAG_SIMULATED); ``` Correct =E2=80=94 VKMS is the canonical virtual/mock KMS driver, entirely s= oftware-based. --- **Summary:** The series is clean and well-structured. The only items worth = flagging to the author: 1. Missing kerneldoc for the new `flags` field in `struct drm_vblank_crtc` = (patch 1). 2. `DRM_VBLANK_FLAG_SIMULATED` starting at `BIT(1)` instead of `BIT(0)` =E2= =80=94 worth confirming this is intentional (patch 2). All driver conversions (patches 3-9) are correct and mechanical. The UAPI c= hange is well-justified by the discussion with compositor maintainers. --- Generated by Claude Code Patch Reviewer