From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Rename and simplify is_rockchip() Date: Thu, 04 Jun 2026 14:37:03 +1000 Message-ID: In-Reply-To: <20260601065100.1103873-10-damon.ding@rock-chips.com> References: <20260601065100.1103873-1-damon.ding@rock-chips.com> <20260601065100.1103873-10-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean refactor renaming `is_rockchip()` to `analogix_dp_is_rockchip()` and converting from chained `||` to `switch`: ```c -static inline bool is_rockchip(enum analogix_dp_devtype type) +static inline bool analogix_dp_is_rockchip(enum analogix_dp_devtype type) { - return type == RK3288_DP || type == RK3399_EDP || type == RK3588_EDP; + switch (type) { + case RK3288_DP: + case RK3399_EDP: + case RK3588_EDP: + return true; + default: + return false; + } } ``` The switch also enables compiler warnings if a new enum value is added without updating the switch (with `-Wswitch`). Correct ordering: this patch goes before Patch 10 which adds RK3576_EDP. Has Reviewed-by from Luca Ceresoli. No issues. --- Generated by Claude Code Patch Reviewer