From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: io_uring/rsrc: extend buffer update Date: Tue, 05 May 2026 11:26:01 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Extends the buffer registration to support the new `io_uring_regbuf_desc` f= ormat via the `IORING_RSRC_UPDATE_EXTENDED` flag. **UAPI concern: `IORING_RSRC_UPDATE_EXTENDED =3D 1U << 1`** The flag uses bit 1 (value 2), skipping bit 0. Was `1U << 0` intentionally = reserved? If not, this should be `1U << 0` for cleaner flag space usage. If= so, a comment explaining what bit 0 is reserved for would be helpful. **Repurposing `resv` field as `flags`** ```c struct io_uring_rsrc_update2 { __u32 offset; - __u32 resv; + __u32 flags; ``` The old code checked `up.resv || up.resv2` to reject non-zero reserved fiel= ds. By renaming `resv` to `flags`, the check is relaxed =E2=80=94 the file = update path now only checks `up.flags` (and rejects non-zero), while the bu= ffer update path accepts `IORING_RSRC_UPDATE_EXTENDED`. The `resv2` check r= emains. This is backward-compatible since old userspace always passed 0 for= `resv`, but it's worth verifying there are no out-of-tree users relying on= the `resv` rejection. --- --- Generated by Claude Code Patch Reviewer