From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8DF4EC1423 for ; Tue, 3 Mar 2026 10:42:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EE9810E774; Tue, 3 Mar 2026 10:42:37 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id F11CD10E774 for ; Tue, 3 Mar 2026 10:42:36 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vxNCc-0005f6-7X; Tue, 03 Mar 2026 11:42:10 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxNCZ-003X1T-2V; Tue, 03 Mar 2026 11:42:09 +0100 Received: from mfe by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1vxNCa-0000000G2ij-47dc; Tue, 03 Mar 2026 11:42:08 +0100 Date: Tue, 3 Mar 2026 11:42:08 +0100 From: Marco Felsch To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , luca.ceresoli@bootlin.com, Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v11 3/3] arm64: dts: imx93: Add parallel display output nodes Message-ID: References: <20260303-v6-18-topic-imx93-parallel-display-v11-0-1b03733c8461@pengutronix.de> <20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Frank, On 26-03-03, Marco Felsch wrote: > Add required OF nodes to support the i.MX93 parallel output (DPI) path. > > On the i.MX93 a single LCDIF is connected to three bridges: DPI, LVDS > LDB and the MIPI-DSI whereas the i.MX91 support only the DPI bridge. > > Map endpoint@0 as DPI bridge output since the i.MX93 TRM (Figure 485. > MEDIAMIX block diagram) doesn't mention any port-number <-> bridge > combination. > > Set the MEDIA-AXI and MEDIA-APB clocks to the overdrive (OD) values > since the i.MX93 and i.MX91 use the overdrive (OD) clk settings per > default. > > Signed-off-by: Marco Felsch Please ignore this particular patch since you already applied this one. Next time we should align the apply with the rest of the patch series if dt-bindings and driver behaviors are involved. In such case the final integration patch should be merged at the end and not at the beginning :) Thanks, Marco > --- > arch/arm64/boot/dts/freescale/imx91_93_common.dtsi | 54 ++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/imx93.dtsi | 12 +++++ > 2 files changed, 66 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi > index 7958cef353766a430df5e626ff2403dc05a974b1..5a8813df6bc993d559fb0b20fc742a106bfe6315 100644 > --- a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi > @@ -1122,8 +1122,62 @@ media_blk_ctrl: system-controller@4ac10000 { > <&clk IMX93_CLK_MIPI_DSI_GATE>; > clock-names = "apb", "axi", "nic", "disp", "cam", > "pxp", "lcdif", "isi", "csi", "dsi"; > + assigned-clocks = <&clk IMX93_CLK_MEDIA_AXI>, > + <&clk IMX93_CLK_MEDIA_APB>, > + <&clk IMX93_CLK_MEDIA_DISP_PIX>; > + assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1>, > + <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>, > + <&clk IMX93_CLK_VIDEO_PLL>; > + assigned-clock-rates = <400000000>, <133333333>; > #power-domain-cells = <1>; > status = "disabled"; > + > + dpi_bridge: dpi-bridge { > + compatible = "nxp,imx93-pdfc"; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + dpi_from_lcdif: endpoint { > + remote-endpoint = <&lcdif_to_dpi>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + dpi_to_panel: endpoint { > + }; > + }; > + }; > + }; > + }; > + > + lcdif: display-controller@4ae30000 { > + compatible = "fsl,imx93-lcdif"; > + reg = <0x4ae30000 0x23c>; > + interrupts = ; > + clocks = <&clk IMX93_CLK_MEDIA_DISP_PIX>, > + <&clk IMX93_CLK_LCDIF_GATE>, > + <&clk IMX93_CLK_MEDIA_AXI>; > + clock-names = "pix", "axi", "disp_axi"; > + power-domains = <&media_blk_ctrl IMX93_MEDIABLK_PD_LCDIF>; > + status = "disabled"; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + lcdif_to_dpi: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dpi_from_lcdif>; > + }; > + }; > }; > > usbotg1: usb@4c100000 { > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi > index 7b27012dfcb564650882dc8c40e836e797b2fda1..5436b48b30e89eb1f939b398ce1bf105abe7e34b 100644 > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > @@ -150,6 +150,18 @@ l3_cache: l3-cache { > }; > }; > > +&lcdif { > + port { > + lcdif_to_ldb: endpoint@1 { > + reg = <1>; > + }; > + > + lcdif_to_dsi: endpoint@2 { > + reg = <2>; > + }; > + }; > +}; > + > &src { > mlmix: power-domain@44461800 { > compatible = "fsl,imx93-src-slice"; > > -- > 2.47.3 > -- #gernperDu #CallMeByMyFirstName Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |