Claude review: drm/i915/display/intel_sdvo: Fix double connector destroy in error paths

Claude Code Review Bot
2026-04-12T00:51:24Z

Patch Review

Correct fix. After `drm_connector_init_with_ddc()` succeeds in `intel_sdvo_connector_init()`, the DRM core owns the connector via the registered `.destroy` callback (`intel_connector_destroy`). The explicit `intel_connector_destroy()` calls in `intel_sdvo_tv_init()` and `intel_sdvo_lvds_init()` error paths were indeed double-free bugs.

The patch simply replaces `goto err` with `return false`, which is correct since the DRM core will handle cleanup during device teardown.

Minor nit: "Not tested as I don't have such hardware" -- the Fixes tag references a commit from 2010. Given the age and the SDVO being legacy hardware, this is reasonable but should get an Ack from an Intel maintainer who can verify the ownership model.

---
Generated by Claude Code Patch Reviewer