From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 768B9EC1434 for ; Tue, 3 Mar 2026 11:36:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3568A10E7D7; Tue, 3 Mar 2026 11:35:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.cz header.i=@suse.cz header.b="MMje5RHt"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="mBJ7uKd5"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="MMje5RHt"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="mBJ7uKd5"; dkim-atps=neutral Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DC8210E795 for ; Tue, 3 Mar 2026 11:22:15 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F3B445BD15; Tue, 3 Mar 2026 11:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772536934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KeUIkqizRv13GXqCMqsXZmgZff1w7sG5Qjbx6Jj7J7Q=; b=MMje5RHtAq0iyN2Ci5NB3siR+5uKf4OabgxeLPpbapGQwdYTZLHIG9WbEhBZtfZH4K6FJj K6dLcOOiweD5MCv526aROGLBnxAitX0xVEFukIg5VKf81+ODBL8aapNjjd2HAUQ3YbMqn7 qxFG09Zg+uhBneAwqCoeimjK9RUv3zM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772536934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KeUIkqizRv13GXqCMqsXZmgZff1w7sG5Qjbx6Jj7J7Q=; b=mBJ7uKd5M1QzjfrDgXpF0iEdCEhfwIvS8TCLCSzoZDho+dSibf/db1v1ycUm9i74WcZRv4 dGapPbtCt8Qt4hAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772536934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KeUIkqizRv13GXqCMqsXZmgZff1w7sG5Qjbx6Jj7J7Q=; b=MMje5RHtAq0iyN2Ci5NB3siR+5uKf4OabgxeLPpbapGQwdYTZLHIG9WbEhBZtfZH4K6FJj K6dLcOOiweD5MCv526aROGLBnxAitX0xVEFukIg5VKf81+ODBL8aapNjjd2HAUQ3YbMqn7 qxFG09Zg+uhBneAwqCoeimjK9RUv3zM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772536934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KeUIkqizRv13GXqCMqsXZmgZff1w7sG5Qjbx6Jj7J7Q=; b=mBJ7uKd5M1QzjfrDgXpF0iEdCEhfwIvS8TCLCSzoZDho+dSibf/db1v1ycUm9i74WcZRv4 dGapPbtCt8Qt4hAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DC5A43EA69; Tue, 3 Mar 2026 11:22:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id EgrGNWXEpmnvRwAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 11:22:13 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 9E82BA0A1B; Tue, 3 Mar 2026 12:22:13 +0100 (CET) Date: Tue, 3 Mar 2026 12:22:13 +0100 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , "Theodore Y. Ts'o" , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "Darrick J. Wong" , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 014/110] proc: use PRIino format for i_ino Message-ID: References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-14-e5388800dae0@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302-iino-u64-v2-14-e5388800dae0@kernel.org> X-Spamd-Result: default: False [-0.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; FORGED_RECIPIENTS(2.00)[m:viro@zeniv.linux.org.uk, m:jack@suse.cz, m:rostedt@goodmis.org, m:mathieu.desnoyers@efficios.com, m:tytso@mit.edu, m:osalvador@suse.de, m:dhowells@redhat.com, m:pc@manguebit.org, m:adilger.kernel@dilger.ca, m:jack@suse.com, m:chuck.lever@oracle.com, m:neil@brown.name, m:okorniev@redhat.com, m:Dai.Ngo@oracle.com, m:tom@talpey.com, m:sfrench@samba.org, m:ronniesahlberg@gmail.com, m:sprasad@microsoft.com, m:bharathsm@microsoft.com, m:alex.aring@gmail.com, m:konishi.ryusuke@gmail.com, m:slava@dubeyko.com, m:asmadeus@codewreck.org, m:linux_oss@crudebyte.com, m:dsterba@suse.com, m:marc.dionne@auristor.com, m:raven@themaw.net, m:salah.triki@gmail.com, m:aivazian.tigran@gmail.com, m:idryomov@gmail.com, m:amarkuze@redhat.com, m:jaharkes@cs.cmu.edu, m:coda@cs.cmu.edu, m:nico@fluxnic.net, m:code@tyhicks.com, m:amir73il@gmail.com, m:glaubitz@physik.fu-berlin.de, m:frank.li@vivo.com, m:mikulas@artax.karlin.mff.cuni.cz, m:richard@nod.at, m:almaz.alexandrovich@paragon-software.com, m:mark@fasheh.com, m:jlbec@evil plan.org, m:hubcap@omnibond.com, m:martin@omnibond.com, m:miklos@szeredi.hu, m:al@alarsen.net, m:naohiro.aota@wdc.com, m:john.johansen@canonical.com, m:paul@paul-moore.com, m:jmorris@namei.org, m:serge@hallyn.com, m:dmitry.kasatkin@gmail.com, m:eric.snowberg@oracle.com, m:stephen.smalley.work@gmail.com, m:omosnace@redhat.com, m:casey@schaufler-ca.com, m:alexander.deucher@amd.com, m:christian.koenig@amd.com, m:airlied@gmail.com, m:simona@ffwll.ch, m:edumazet@google.com, m:kuniyu@google.com, m:pabeni@redhat.com, m:willemb@google.com, m:davem@davemloft.net, m:oleg@redhat.com, m:mingo@redhat.com, s:adrian.hunter@intel.com, s:maciej.fijalkowski@intel.com, s:magnus.karlsson@intel.com, s:daniel@iogearbox.net, s:ast@kernel.org, s:djwong@kernel.org, s:dsahern@kernel.org, s:hawk@kernel.org, s:jolsa@kernel.org, s:linux-mm@kvack.org, s:james.clark@linaro.org, s:alexander.shishkin@linux.intel.com, s:amd-gfx@lists.freedesktop.org, s:dri-devel@lists.freedesktop.org, s:linux-afs@lists.infradead.org, s:linux-mtd@lists.infradead.org, s:linar o-mm-sig@lists.linaro.org,s:fsverity@lists.linux.dev,s:netfs@lists.linux.dev,s:ntfs3@lists.linux.dev]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; TAGGED_RCPT(0.00)[]; FREEMAIL_CC(0.00)[zeniv.linux.org.uk, kernel.org, suse.cz, goodmis.org, efficios.com, intel.com, infradead.org, mit.edu, linux.dev, suse.de, redhat.com, manguebit.org, dilger.ca, suse.com, oracle.com, brown.name, talpey.com, samba.org, gmail.com, microsoft.com, dubeyko.com, ionkov.net, codewreck.org, crudebyte.com, auristor.com, themaw.net, cs.cmu.edu, fluxnic.net, tyhicks.com, physik.fu-berlin.de, vivo.com, artax.karlin.mff.cuni.cz, nod.at, paragon-software.com, fasheh.com, evilplan.org, linux.alibaba.com, omnibond.com, szeredi.hu, alarsen.net, huawei.com, wdc.com, canonical.com, paul-moore.com, namei.org, hallyn.com, linux.ibm.com, schaufler-ca.com, amd.com, ffwll.ch, linaro.org, google.com, davemloft.net, arm.com, linux.intel.com, dev.tdt.de, yaina.de, holtmann.org, hartkopp.net, pengutronix.de, secunet.com, gondor.apana.org.au, fomichev.me, iogearbox.net, vger.kernel.org, lists.linux.dev, kvack.org, lists.sourceforge.net, lists.samba.org, lists.infradead.org, coda.cs.cmu.edu, lists.orangefs.org, lists.ubuntu.com, lists.freedesktop.org, lists.linaro.or g]; RCVD_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLzmnxm7msfpf7ixykpj9feesk)]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_GT_50(0.00)[172]; RCVD_TLS_LAST(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.com:email, suse.cz:email] X-Mailman-Approved-At: Tue, 03 Mar 2026 11:35:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon 02-03-26 15:23:58, Jeff Layton wrote: > Convert proc i_ino format strings to use the PRIino format > macro in preparation for the widening of i_ino via kino_t. > > Update local variables and function parameters that hold i_ino > values from unsigned long to kino_t. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/proc/fd.c | 2 +- > fs/proc/task_mmu.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/fd.c b/fs/proc/fd.c > index 9eeccff49b2abf57d766ce17fe47070c379ed2c8..936d0258d688be5fdc384ee5c4dfbb8fa0d19dff 100644 > --- a/fs/proc/fd.c > +++ b/fs/proc/fd.c > @@ -54,7 +54,7 @@ static int seq_show(struct seq_file *m, void *v) > if (ret) > return ret; > > - seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\nino:\t%lu\n", > + seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\nino:\t%" PRIino "u\n", > (long long)file->f_pos, f_flags, > real_mount(file->f_path.mnt)->mnt_id, > file_inode(file)->i_ino); > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index e091931d7ca19d71f31699913d177eec0821ca7b..702b0f0433f91077cd0d0af4a07e9d67d9fa9a45 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -442,7 +442,7 @@ static void get_vma_name(struct vm_area_struct *vma, > static void show_vma_header_prefix(struct seq_file *m, > unsigned long start, unsigned long end, > vm_flags_t flags, unsigned long long pgoff, > - dev_t dev, unsigned long ino) > + dev_t dev, kino_t ino) > { > seq_setwidth(m, 25 + sizeof(void *) * 6 - 1); > seq_put_hex_ll(m, NULL, start, 8); > @@ -465,7 +465,7 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma) > const struct path *path; > const char *name_fmt, *name; > vm_flags_t flags = vma->vm_flags; > - unsigned long ino = 0; > + kino_t ino = 0; > unsigned long long pgoff = 0; > unsigned long start, end; > dev_t dev = 0; > > -- > 2.53.0 > -- Jan Kara SUSE Labs, CR