From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: David Airlie <airlied@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] drm/rcar-du: Drop superfluous spaces after assignments
Date: Mon, 04 May 2026 09:11:21 +0100 [thread overview]
Message-ID: <177788228188.45302.9594019404927871888@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <80e30578b6dd86664112320616c460c48dbd79f6.1777881435.git.geert+renesas@glider.be>
Quoting Geert Uytterhoeven (2026-05-04 08:58:23)
> There is no need for a double space after an assignment.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Lets stop these copying then:
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> This started with two instances, and got copied each time support for
> a new SoC was added...
> ---
> drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> index 031d07f4508e9762..d9926c24984eb3db 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> @@ -137,7 +137,7 @@ static const struct rcar_du_device_info rcar_du_r8a774a1_info = {
> },
> .num_lvds = 1,
> .num_rpf = 5,
> - .dpll_mask = BIT(1),
> + .dpll_mask = BIT(1),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a774b1_info = {
> @@ -168,7 +168,7 @@ static const struct rcar_du_device_info rcar_du_r8a774b1_info = {
> },
> .num_lvds = 1,
> .num_rpf = 5,
> - .dpll_mask = BIT(1),
> + .dpll_mask = BIT(1),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a774c0_info = {
> @@ -196,7 +196,7 @@ static const struct rcar_du_device_info rcar_du_r8a774c0_info = {
> },
> .num_lvds = 2,
> .num_rpf = 4,
> - .lvds_clk_mask = BIT(1) | BIT(0),
> + .lvds_clk_mask = BIT(1) | BIT(0),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a774e1_info = {
> @@ -227,7 +227,7 @@ static const struct rcar_du_device_info rcar_du_r8a774e1_info = {
> },
> .num_lvds = 1,
> .num_rpf = 5,
> - .dpll_mask = BIT(1),
> + .dpll_mask = BIT(1),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> @@ -385,7 +385,7 @@ static const struct rcar_du_device_info rcar_du_r8a7795_info = {
> },
> .num_lvds = 1,
> .num_rpf = 5,
> - .dpll_mask = BIT(2) | BIT(1),
> + .dpll_mask = BIT(2) | BIT(1),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a7796_info = {
> @@ -416,7 +416,7 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = {
> },
> .num_lvds = 1,
> .num_rpf = 5,
> - .dpll_mask = BIT(1),
> + .dpll_mask = BIT(1),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a77965_info = {
> @@ -447,7 +447,7 @@ static const struct rcar_du_device_info rcar_du_r8a77965_info = {
> },
> .num_lvds = 1,
> .num_rpf = 5,
> - .dpll_mask = BIT(1),
> + .dpll_mask = BIT(1),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a77970_info = {
> @@ -502,7 +502,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = {
> },
> .num_lvds = 2,
> .num_rpf = 5,
> - .lvds_clk_mask = BIT(1) | BIT(0),
> + .lvds_clk_mask = BIT(1) | BIT(0),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a779a0_info = {
> @@ -523,7 +523,7 @@ static const struct rcar_du_device_info rcar_du_r8a779a0_info = {
> },
> },
> .num_rpf = 5,
> - .dsi_clk_mask = BIT(1) | BIT(0),
> + .dsi_clk_mask = BIT(1) | BIT(0),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a779g0_info = {
> @@ -544,7 +544,7 @@ static const struct rcar_du_device_info rcar_du_r8a779g0_info = {
> },
> },
> .num_rpf = 5,
> - .dsi_clk_mask = BIT(1) | BIT(0),
> + .dsi_clk_mask = BIT(1) | BIT(0),
> };
>
> static const struct rcar_du_device_info rcar_du_r8a779h0_info = {
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-05-04 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 7:58 [PATCH] drm/rcar-du: Drop superfluous spaces after assignments Geert Uytterhoeven
2026-05-04 8:11 ` Kieran Bingham [this message]
2026-05-04 22:30 ` Claude review: " Claude Code Review Bot
2026-05-04 22:30 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177788228188.45302.9594019404927871888@ping.linuxembedded.co.uk \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox