From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rcar-du: Drop superfluous spaces after assignments
Date: Tue, 05 May 2026 08:30:44 +1000 [thread overview]
Message-ID: <review-patch1-80e30578b6dd86664112320616c460c48dbd79f6.1777881435.git.geert+renesas@glider.be> (raw)
In-Reply-To: <80e30578b6dd86664112320616c460c48dbd79f6.1777881435.git.geert+renesas@glider.be>
Patch Review
**Status: Clean**
The patch fixes 10 instances of double-space after `=` across various `rcar_du_device_info` struct initializers:
- 7 instances of `.dpll_mask = BIT(...)` → `.dpll_mask = BIT(...)`
- 2 instances of `.lvds_clk_mask = BIT(...)` → `.lvds_clk_mask = BIT(...)`
- 1 instance of `.dsi_clk_mask = BIT(...)` → `.dsi_clk_mask = BIT(...)`
Wait — looking more carefully, there are actually 2 `dsi_clk_mask` fixes (lines 143-144 and 152-153), 2 `lvds_clk_mask` fixes, and 6 `dpll_mask` fixes, totaling the 10 stated in the diffstat.
Each hunk is a single-character whitespace deletion with identical surrounding context confirming it's the right field. No semantic or behavioral change. The commit message accurately describes the change, and the `---` note explaining the origin of the pattern is useful.
**Reviewed-by worthy.** No concerns.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-04 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 7:58 [PATCH] drm/rcar-du: Drop superfluous spaces after assignments Geert Uytterhoeven
2026-05-04 8:11 ` Kieran Bingham
2026-05-04 22:30 ` Claude review: " Claude Code Review Bot
2026-05-04 22:30 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-80e30578b6dd86664112320616c460c48dbd79f6.1777881435.git.geert+renesas@glider.be \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox