[PATCH] drm/rcar-du: Drop superfluous spaces after assignments

[PATCH] drm/rcar-du: Drop superfluous spaces after assignments

[Geert Uytterhoeven]

There is no need for a double space after an assignment.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This started with two instances, and got copied each time support for
a new SoC was added...
---
 drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
index 031d07f4508e9762..d9926c24984eb3db 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
@@ -137,7 +137,7 @@ static const struct rcar_du_device_info rcar_du_r8a774a1_info = {
 	},
 	.num_lvds = 1,
 	.num_rpf = 5,
-	.dpll_mask =  BIT(1),
+	.dpll_mask = BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a774b1_info = {
@@ -168,7 +168,7 @@ static const struct rcar_du_device_info rcar_du_r8a774b1_info = {
 	},
 	.num_lvds = 1,
 	.num_rpf = 5,
-	.dpll_mask =  BIT(1),
+	.dpll_mask = BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a774c0_info = {
@@ -196,7 +196,7 @@ static const struct rcar_du_device_info rcar_du_r8a774c0_info = {
 	},
 	.num_lvds = 2,
 	.num_rpf = 4,
-	.lvds_clk_mask =  BIT(1) | BIT(0),
+	.lvds_clk_mask = BIT(1) | BIT(0),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a774e1_info = {
@@ -227,7 +227,7 @@ static const struct rcar_du_device_info rcar_du_r8a774e1_info = {
 	},
 	.num_lvds = 1,
 	.num_rpf = 5,
-	.dpll_mask =  BIT(1),
+	.dpll_mask = BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a7779_info = {
@@ -385,7 +385,7 @@ static const struct rcar_du_device_info rcar_du_r8a7795_info = {
 	},
 	.num_lvds = 1,
 	.num_rpf = 5,
-	.dpll_mask =  BIT(2) | BIT(1),
+	.dpll_mask = BIT(2) | BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a7796_info = {
@@ -416,7 +416,7 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = {
 	},
 	.num_lvds = 1,
 	.num_rpf = 5,
-	.dpll_mask =  BIT(1),
+	.dpll_mask = BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a77965_info = {
@@ -447,7 +447,7 @@ static const struct rcar_du_device_info rcar_du_r8a77965_info = {
 	},
 	.num_lvds = 1,
 	.num_rpf = 5,
-	.dpll_mask =  BIT(1),
+	.dpll_mask = BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a77970_info = {
@@ -502,7 +502,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = {
 	},
 	.num_lvds = 2,
 	.num_rpf = 5,
-	.lvds_clk_mask =  BIT(1) | BIT(0),
+	.lvds_clk_mask = BIT(1) | BIT(0),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a779a0_info = {
@@ -523,7 +523,7 @@ static const struct rcar_du_device_info rcar_du_r8a779a0_info = {
 		},
 	},
 	.num_rpf = 5,
-	.dsi_clk_mask =  BIT(1) | BIT(0),
+	.dsi_clk_mask = BIT(1) | BIT(0),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a779g0_info = {
@@ -544,7 +544,7 @@ static const struct rcar_du_device_info rcar_du_r8a779g0_info = {
 		},
 	},
 	.num_rpf = 5,
-	.dsi_clk_mask =  BIT(1) | BIT(0),
+	.dsi_clk_mask = BIT(1) | BIT(0),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a779h0_info = {
-- 
2.43.0

Re: [PATCH] drm/rcar-du: Drop superfluous spaces after assignments

[Kieran Bingham]

Quoting Geert Uytterhoeven (2026-05-04 08:58:23)
> There is no need for a double space after an assignment.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Lets stop these copying then:


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
> This started with two instances, and got copied each time support for
> a new SoC was added...
> ---
>  drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> index 031d07f4508e9762..d9926c24984eb3db 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> @@ -137,7 +137,7 @@ static const struct rcar_du_device_info rcar_du_r8a774a1_info = {
>         },
>         .num_lvds = 1,
>         .num_rpf = 5,
> -       .dpll_mask =  BIT(1),
> +       .dpll_mask = BIT(1),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a774b1_info = {
> @@ -168,7 +168,7 @@ static const struct rcar_du_device_info rcar_du_r8a774b1_info = {
>         },
>         .num_lvds = 1,
>         .num_rpf = 5,
> -       .dpll_mask =  BIT(1),
> +       .dpll_mask = BIT(1),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a774c0_info = {
> @@ -196,7 +196,7 @@ static const struct rcar_du_device_info rcar_du_r8a774c0_info = {
>         },
>         .num_lvds = 2,
>         .num_rpf = 4,
> -       .lvds_clk_mask =  BIT(1) | BIT(0),
> +       .lvds_clk_mask = BIT(1) | BIT(0),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a774e1_info = {
> @@ -227,7 +227,7 @@ static const struct rcar_du_device_info rcar_du_r8a774e1_info = {
>         },
>         .num_lvds = 1,
>         .num_rpf = 5,
> -       .dpll_mask =  BIT(1),
> +       .dpll_mask = BIT(1),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> @@ -385,7 +385,7 @@ static const struct rcar_du_device_info rcar_du_r8a7795_info = {
>         },
>         .num_lvds = 1,
>         .num_rpf = 5,
> -       .dpll_mask =  BIT(2) | BIT(1),
> +       .dpll_mask = BIT(2) | BIT(1),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a7796_info = {
> @@ -416,7 +416,7 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = {
>         },
>         .num_lvds = 1,
>         .num_rpf = 5,
> -       .dpll_mask =  BIT(1),
> +       .dpll_mask = BIT(1),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a77965_info = {
> @@ -447,7 +447,7 @@ static const struct rcar_du_device_info rcar_du_r8a77965_info = {
>         },
>         .num_lvds = 1,
>         .num_rpf = 5,
> -       .dpll_mask =  BIT(1),
> +       .dpll_mask = BIT(1),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a77970_info = {
> @@ -502,7 +502,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = {
>         },
>         .num_lvds = 2,
>         .num_rpf = 5,
> -       .lvds_clk_mask =  BIT(1) | BIT(0),
> +       .lvds_clk_mask = BIT(1) | BIT(0),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a779a0_info = {
> @@ -523,7 +523,7 @@ static const struct rcar_du_device_info rcar_du_r8a779a0_info = {
>                 },
>         },
>         .num_rpf = 5,
> -       .dsi_clk_mask =  BIT(1) | BIT(0),
> +       .dsi_clk_mask = BIT(1) | BIT(0),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a779g0_info = {
> @@ -544,7 +544,7 @@ static const struct rcar_du_device_info rcar_du_r8a779g0_info = {
>                 },
>         },
>         .num_rpf = 5,
> -       .dsi_clk_mask =  BIT(1) | BIT(0),
> +       .dsi_clk_mask = BIT(1) | BIT(0),
>  };
>  
>  static const struct rcar_du_device_info rcar_du_r8a779h0_info = {
> -- 
> 2.43.0
>

Claude review: drm/rcar-du: Drop superfluous spaces after assignments

[Claude Code Review Bot]

Overall Series Review

Subject: drm/rcar-du: Drop superfluous spaces after assignments
Author: Geert Uytterhoeven <geert+renesas@glider.be>
Patches: 2
Reviewed: 2026-05-05T08:30:43.887825

---

This is a single-patch cosmetic cleanup from Geert Uytterhoeven targeting `drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c`. It removes superfluous double spaces after `=` in struct initializer assignments (`.dpll_mask =  BIT(...)` → `.dpll_mask = BIT(...)`). The patch is trivially correct and has no functional impact.

**Verdict: No issues. Patch looks good.**

The commit message is clear, the cover-letter note about the pattern being copied from two original instances across SoC additions is a nice touch of context. All 10 hunks are mechanically identical in nature — removing one extra space character.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/rcar-du: Drop superfluous spaces after assignments

[Claude Code Review Bot]

Patch Review

**Status: Clean**

The patch fixes 10 instances of double-space after `=` across various `rcar_du_device_info` struct initializers:

- 7 instances of `.dpll_mask =  BIT(...)` → `.dpll_mask = BIT(...)`
- 2 instances of `.lvds_clk_mask =  BIT(...)` → `.lvds_clk_mask = BIT(...)`  
- 1 instance of `.dsi_clk_mask =  BIT(...)` → `.dsi_clk_mask = BIT(...)`

Wait — looking more carefully, there are actually 2 `dsi_clk_mask` fixes (lines 143-144 and 152-153), 2 `lvds_clk_mask` fixes, and 6 `dpll_mask` fixes, totaling the 10 stated in the diffstat.

Each hunk is a single-character whitespace deletion with identical surrounding context confirming it's the right field. No semantic or behavioral change. The commit message accurately describes the change, and the `---` note explaining the origin of the pattern is useful.

**Reviewed-by worthy.** No concerns.

---
Generated by Claude Code Patch Reviewer