From: "Rob Herring (Arm)" <robh@kernel.org>
To: Damon Ding <damon.ding@rock-chips.com>
Cc: mripard@kernel.org, luca.ceresoli@bootlin.com,
tzimmermann@suse.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
dmitry.baryshkov@oss.qualcomm.com, conor+dt@kernel.org,
cristian.ciocaltea@collabora.com,
Laurent.pinchart@ideasonboard.com, rfoss@kernel.org,
sebastian.reichel@collabora.com,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, andy.yan@rock-chips.com,
andrzej.hajda@intel.com, jernej.skrabec@gmail.com,
simona@ffwll.ch, devicetree@vger.kernel.org,
nicolas.frattaroli@collabora.com, m.szyprowski@samsung.com,
Conor Dooley <conor.dooley@microchip.com>,
hjc@rock-chips.com, airlied@gmail.com,
maarten.lankhorst@linux.intel.com, jonas@kwiboo.se,
dianders@chromium.org, heiko@sntech.de,
neil.armstrong@linaro.org
Subject: Re: [PATCH v7 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576
Date: Mon, 25 May 2026 06:13:47 -0500 [thread overview]
Message-ID: <177970762670.3598384.1698792096821270137.robh@kernel.org> (raw)
In-Reply-To: <20260525082033.117569-7-damon.ding@rock-chips.com>
On Mon, 25 May 2026 16:20:29 +0800, Damon Ding wrote:
> RK3576 integrates an eDP TX controller compatible with the existing
> RK3588 hardware design, reuse the same binding configuration directly.
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
>
> ---
>
> Changes in v2:
> - Split out a separate patch to add the "hclk" clock reference.
>
> Chanegs in v4:
> - Modify the commit msg.
>
> Changes in v5:
> - Add Acked-by tag.
> ---
> .../bindings/display/rockchip/rockchip,analogix-dp.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml:34:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260525082033.117569-7-damon.ding@rock-chips.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-05-25 11:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 8:20 [PATCH v7 00/10] Add eDP support for RK3576 Damon Ding
2026-05-25 8:20 ` [PATCH v7 01/10] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 Damon Ding
2026-05-25 9:42 ` Damon Ding
2026-05-25 11:43 ` Rob Herring (Arm)
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 02/10] dt-bindings: display: rockchip: analogix-dp: Add per-clock descriptions Damon Ding
2026-05-25 11:13 ` Rob Herring (Arm)
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 04/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP1 Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-05-25 11:13 ` Rob Herring (Arm) [this message]
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 07/10] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 09/10] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:20 ` [PATCH v7 10/10] drm/rockchip: " Damon Ding
2026-05-25 21:34 ` Claude review: " Claude Code Review Bot
2026-05-25 21:34 ` Claude review: Add eDP " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177970762670.3598384.1698792096821270137.robh@kernel.org \
--to=robh@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=damon.ding@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=rfoss@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox