public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: analogix_dp: Enable hclk for RK3588
Date: Tue, 26 May 2026 07:34:41 +1000	[thread overview]
Message-ID: <review-patch5-20260525082033.117569-6-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260525082033.117569-6-damon.ding@rock-chips.com>

Patch Review

Acquires the hclk using `devm_clk_get_optional_enabled()`:

```c
+	clk = devm_clk_get_optional_enabled(dev, "hclk");
+	if (IS_ERR(clk))
+		return dev_err_probe(dev, PTR_ERR(clk),
+				     "failed to get hclk property\n");
```

Good use of `devm_clk_get_optional_enabled()` -- it handles both the "not present" case (for RK3288/RK3399) and the error case cleanly. The clock is managed by devres so it stays enabled for the device lifetime, which matches the commit message's statement that hclk "must remain enabled during probe." The local `clk` variable is unused after the call, which is fine since devm handles the lifecycle.

One thing to note: this means hclk is always-on once probed. The existing `pclk` is toggled in `rockchip_dp_poweron`/`rockchip_dp_powerdown`, but hclk is not. Per the commit message this is intentional ("must remain enabled during probe") and the hardware requires it to stay on for datapath gating. This seems correct.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 21:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  8:20 [PATCH v7 00/10] Add eDP support for RK3576 Damon Ding
2026-05-25  8:20 ` [PATCH v7 01/10] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 Damon Ding
2026-05-25  9:42   ` Damon Ding
2026-05-25 11:43   ` Rob Herring (Arm)
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 02/10] dt-bindings: display: rockchip: analogix-dp: Add per-clock descriptions Damon Ding
2026-05-25 11:13   ` Rob Herring (Arm)
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 04/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP1 Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-25 21:34   ` Claude Code Review Bot [this message]
2026-05-25  8:20 ` [PATCH v7 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-05-25 11:13   ` Rob Herring (Arm)
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 07/10] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 09/10] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 ` [PATCH v7 10/10] drm/rockchip: " Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-25 21:34 ` Claude review: Add eDP " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-27  2:43 [PATCH v9 00/10] " Damon Ding
2026-05-27  2:43 ` [PATCH v9 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-27  3:55   ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 [PATCH v8 00/10] Add eDP support for RK3576 Damon Ding
2026-05-25 12:53 ` [PATCH v8 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-25 21:12   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 [PATCH v6 00/10] Add eDP support for RK3576 Damon Ding
2026-05-21  8:08 ` [PATCH v6 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-13  7:44 [PATCH v5 00/10] Add eDP support for RK3576 Damon Ding
2026-05-13  7:44 ` [PATCH v5 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-16  2:26   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260525082033.117569-6-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox